intellihide: fix overlap check getting permanently stuck#2552
Open
Alisson-Frota-Soares wants to merge 1 commit intomicheleg:masterfrom
Open
intellihide: fix overlap check getting permanently stuck#2552Alisson-Frota-Soares wants to merge 1 commit intomicheleg:masterfrom
Alisson-Frota-Soares wants to merge 1 commit intomicheleg:masterfrom
Conversation
If _doCheckOverlap() throws inside the throttle timeout callback (e.g. due to a null workspace on transient windows in GNOME 48), _checkOverlapTimeoutId is never reset to 0. All subsequent _checkOverlap() calls short-circuit, permanently freezing the dock in its current visibility state. Fixes: - Wrap _doCheckOverlap() in try-catch inside timeout callback - Guard against null workspace/meta_window in filter - Guard against null compositor private in _windowCreated - Prevent duplicate signal handlers in _addWindowSignals - Clear stale timeout state in enable() Fixes: micheleg#2551
3v1n0
reviewed
Mar 27, 2026
| enable() { | ||
| this._isEnabled = true; | ||
| this._status = OverlapStatus.UNDEFINED; | ||
| this._checkOverlapTimeoutContinue = false; |
Collaborator
There was a problem hiding this comment.
If you're removing the timeout, this call has no effect. Otherwise _checkOverlapTimeoutContinue is unset (thus false) by default.
Maybe you do want to remove the timeout on disable though.
3v1n0
reviewed
Mar 27, 2026
|
|
||
| _windowCreated(display, metaWindow) { | ||
| this._addWindowSignals(metaWindow.get_compositor_private()); | ||
| const dominated = metaWindow.get_compositor_private(); |
Collaborator
There was a problem hiding this comment.
If've a metaWindow, then we also have a the compositor private side.
3v1n0
reviewed
Mar 27, 2026
| return false; | ||
| const currentWorkspace = global.workspace_manager.get_active_workspace_index(); | ||
| const workspace = metaWin.get_workspace(); | ||
| if (!workspace) |
Collaborator
There was a problem hiding this comment.
IIRC this can happen only if the window is being destroyed, so in such case we should not even be here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If _doCheckOverlap() throws inside the throttle timeout callback (e.g. due to a null workspace on transient windows in GNOME 48), _checkOverlapTimeoutId is never reset to 0. All subsequent _checkOverlap() calls short-circuit, permanently freezing the dock in its current visibility state.
Fixes:
Fixes: #2551