fix: Add corner case of a tripartite content type#147
Open
Zzull wants to merge 1 commit intometosin:masterfrom
Open
fix: Add corner case of a tripartite content type#147Zzull wants to merge 1 commit intometosin:masterfrom
Zzull wants to merge 1 commit intometosin:masterfrom
Conversation
The Ring-Mock library (to create Ring request map for testing purposes) sets a tripartite content type on multipart parameters that would raise a "Can't negotiate on request charset" exception.
Member
|
Interesting that we haven't caught this before! I'll want to check the HTTP spec if there is anything about the order of the parameters, or if we should prepare to support cases where another parameter comes before the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ring-Mock library (to create Ring request map for testing purposes) sets a tripartite content type on multipart parameters that would raise a "Can't negotiate on request charset" exception.