Make PM metrics float - #874
Closed
oscgonfer wants to merge 3 commits into
Closed
Conversation
[pull] master from meshtastic:master
[pull] master from meshtastic:master
Contributor
Author
|
Discarded. Will apply scale if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many new PM sensors support floats for PM readings. This increases payload size with the varint-to-float move, but the gain in precision is worth it for me. Note that I am not changing the pm_environmental, because the only sensor that provides that is the PMS, and they are ints.
Since this is a breaking change, I let it to @caveman99 to see if it can be included in future versions where other things are refactored.