Skip to content

fix: make sendError payload format respect WebSocket subprotocol #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsushanth wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: make sendError payload format respect WebSocket subprotocol #1255

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9de417d
fix: make sendError payload format respect WebSocket subprotocol
tsushanth Jul 16, 2026
f998e72
test: add unit tests for sendError protocol-aware payload format
tsushanth Jul 16, 2026
87eb065
fix(subscriptions): use resolved protocol in sendError, not raw socke…
sushanth9 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/subscription-connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,11 @@ module.exports = class SubscriptionConnection {

sendError (err, id) {
const convertedError = toGraphQLError(err)
// Graphql over websocket spec requires that errors are wrapped in an array
this.sendMessage(this.protocolMessageTypes.GQL_ERROR, id, [convertedError])
// graphql-transport-ws requires errors wrapped in an array; the legacy
// subscriptions-transport-ws protocol (identified as 'graphql-ws') expects
// a single error object instead.
const payload = this.socket.protocol === 'graphql-ws' ? convertedError : [convertedError]
this.sendMessage(this.protocolMessageTypes.GQL_ERROR, id, payload)
}

async handleConnectionInitExtension (extension) {
Expand Down
Loading