Fix loader batching logic in defineLoader + upgrade dependencies and GraphiQL - #1143
Open
acoBOYZ wants to merge 1 commit into
Open
Fix loader batching logic in defineLoader + upgrade dependencies and GraphiQL#1143acoBOYZ wants to merge 1 commit into
acoBOYZ wants to merge 1 commit into
Conversation
mcollina
requested changes
Apr 10, 2025
mcollina
left a comment
Collaborator
There was a problem hiding this comment.
Can you add some tests as well?
| return query | ||
|
|
||
| return stringify({ obj, params }) | ||
| } |
Collaborator
There was a problem hiding this comment.
I don't think this is generic enough to be included in the library. How about you add a a way to include a custom serializer for the loader instead?
Contributor
Author
There was a problem hiding this comment.
You are right. I found a better way to handle it. Also i will add some tests for it. After that if you like it can pr docs for that too. I will publish it soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix internal
defineLoaderbatching issue + dependency & GraphiQL updatesThis pull request fixes a problem in Mercurius' internal
defineLoaderfunction, where GraphQL field loaders were being called once per item, instead of once per field with batching.✅ What was fixed
The problem was caused by using complex objects (
{ obj, params }) as loader keys, which prevented Mercurius from recognizing repeated calls as "the same".We now use a
serialize()function that:obj.idandparams.langto create a fast and consistent batching keyJSON.stringify({ obj, params })ifidis not available✅ Also included
main.js,config.js) to the latest version🧪 Real-world test results (
k6)Before (no batching):
After (with batching):
🔒 Notes