feat: make request available in context by default - #1088
Open
adtennant wants to merge 2 commits into
Open
Conversation
Collaborator
|
CI does not seem happy |
Contributor
|
Looking at the error in the CI, I think the issue is fixed in main (by this PR the other day: #1090) @adtennant Maybe worth a quick rebase and re-run to be on the safe side? |
mcollina
requested changes
Apr 1, 2024
mcollina
left a comment
mcollina
left a comment
Collaborator
There was a problem hiding this comment.
I just noticed this is missing a test. Could you add it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this is very easy to define a custom context for, but it's annoying to have to do it (or do
reply.request) every time and this is a closer match to standard Fastify handlers.