Skip to content

chore(opennebula): enable mypy type checking#1

Closed
mcanevet wants to merge 6 commits intomainfrom
fix/opennebula-enable-mypy
Closed

chore(opennebula): enable mypy type checking#1
mcanevet wants to merge 6 commits intomainfrom
fix/opennebula-enable-mypy

Conversation

@mcanevet
Copy link
Copy Markdown
Owner

@mcanevet mcanevet commented Apr 2, 2026

Proposed Commit Message

chore(opennebula): enable mypy type checking

Add type annotations to DataSourceOpenNebula.py to address concerns
raised in PR #6810 about type checking being disabled for the
OpenNebula datasource.

Refs GH-6810

Additional Context

This is a prerequisite for merging PR canonical#6810 which adds ETHx_ROUTES support.

Test Steps

  • mypy passes
  • unit tests pass (50/50)

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

hcartiaux and others added 6 commits March 30, 2026 12:25
@hcartiaux
fix(openbsd): specify the correct usr_lib_exec path (canonical#6793)
35f5948
@holmanb
ci: disable daily jobs on forks (canonical#6821)
17d2867
@holmanb
chore: drop unnecessary pylint ignore settings, use pytest --strict-m…
0b7dc7e 
…arkers (canonical#6817)
@blackboxsw
tools: fix brpm script to use correct builddir in temp directory (can…
65bacbe 
…onical#6809)

RockyLinux 9 has Jinja 2.11. Template-based unit tests break due to
unsupported closure: +%}.

Revert portion of 473fa33 to retain skip decorator avoiding unit test
when Jinja is < 3.0.0 to support rockylinux developer rpm builds.

Update ruff extra-includes to validate read-dependencies, bddeb and brpm.
@ani-sinha
test: fix test_schema when the schema validation takes longer (canoni…
ffd26f1 
…cal#6822)

When the schema validation takes more than 0.01 seconds, a log is emitted:
"Validating schema took 0.070 seconds"

When this happens, the tuple length is 2 and not one and the test test_validateconfig_schema_non_strict_emits_warnings fails.

Fix it by checking if the length of the tuple is either one or two,
not just one.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
@mcanevet
chore(opennebula): enable mypy type checking
c4fac41 
Add type annotations to DataSourceOpenNebula.py to address concerns
raised in PR canonical#6810 about type checking being disabled for the
OpenNebula datasource.

Refs canonicalGH-6810
@mcanevet mcanevet closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcanevet @hcartiaux @holmanb @blackboxsw @ani-sinha