Skip to content

fix: connecting_routes script broken IO.puts#2982

Merged
robbie-sundstrom merged 11 commits intomainfrom
rs/fix-connecting-routes-script
Mar 31, 2026
Merged

fix: connecting_routes script broken IO.puts#2982
robbie-sundstrom merged 11 commits intomainfrom
rs/fix-connecting-routes-script

Conversation

@robbie-sundstrom
Copy link
Copy Markdown
Contributor

The IO.puts statement in the connecting_routes script wasn't working because it was taking a List of Lists of strings.

  • Added a helper function that prints out the connecting routes more cleanly. Sorry for the messy commits, but this change is here: 7fa16b3
  • mix formatted the function by our code standards as this made it much easier to parse

Example of the connecting routes printed out below:
image

@robbie-sundstrom robbie-sundstrom requested a review from a team as a code owner March 31, 2026 18:32
Copy link
Copy Markdown
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mix formatted the function by our code standards as this made it much easier to parse

We could add the scripts path to .formatter.exs so it happens consistently with mix format / is included in CI.

@robbie-sundstrom
Copy link
Copy Markdown
Contributor Author

@digitalcora I was right behind you! Pushed the change to the .formatter.exs right as you approved

@robbie-sundstrom robbie-sundstrom merged commit 981c96f into main Mar 31, 2026
12 checks passed
@robbie-sundstrom robbie-sundstrom deleted the rs/fix-connecting-routes-script branch March 31, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants