Conversation
|
@deanshi Your DUP screenshot shows "real-time" ferry departures... but we don't have real-time tracking of ferries at all (not yet anyway). So I think something's off with the implementation 😅 |
Updated the logic to exclude ferries (and also fix scheduled rail departures that do not have a prediction) and updated the screenshots! |
|
|
||
| .departure-time__timestamp { | ||
| display: inline-block; | ||
| text-decoration: inherit; |
There was a problem hiding this comment.
According to some Stack Overflow and some docs, text-decoration doesn't get inherited when we set display: inline-block without explicitly defining the inherit here for the strikethrough text. I think if we wanted to, we could adjust how some of this CSS is structured but I figured this would be the simplest way.
| Departures.serialize_times_with_crowding([departure], bus_shelter_screen, now) | ||
| end | ||
|
|
||
| test "is not live data for scheduled ferry", %{dup_screen: screen} do |
There was a problem hiding this comment.
This test case seems superfluous now as it's exercising the same code path as the one just below.
- Live Icon for departures added next to the time - Crowding icon resized to allow for both icons to fit in cases where we have them - Increased the departure time div size for departures, decreased the headsign size on both LCD and DUP screens - Do not show the live icon for ferry departures and scheduled rail departures
deanshi
force-pushed
the
deanshi/live_icon_lcd_screens
branch
from
ca45c38 to
e48f0e1
Compare
2 participants
Asana task: Implement "live" icon on LCD Screen departures
Description