feat(SubwayStatus): Show effect if unique when combining Green Line rows#3315
Open
joshlarson wants to merge 3 commits into
Open
feat(SubwayStatus): Show effect if unique when combining Green Line rows#3315joshlarson wants to merge 3 commits into
joshlarson wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket:⚠️ Update homepage subway status to support multiple GL branch station bypasses
Implementation
:station_closure), then show the label text for that status, rather than "Screenshots
main(shown indev-greenso I could try out different combos). Notice how it indiscriminately collapses to "How to test
Compare homepage subway status with alerts page subway status. Create alerts on different branches of the Green line with the same effects, and see that they show that effect (e.g.
Stops Skipped). Create alerts with different effects or different start times and see that they still collapse toSee Alerts. Try other scenarios that I didn't think of. Have fun!