feat(dev): Add flamegraphs to live dashboard in non-prod#3313
Draft
joshlarson wants to merge 1 commit into
Draft
feat(dev): Add flamegraphs to live dashboard in non-prod#3313joshlarson wants to merge 1 commit into
joshlarson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
No ticket, but this tool has been quite helpful for profiling things like the homepage load times. So far, we've been using it by cherry-picking this commit onto different pieces of work, but I don't see any reason we couldn't just commit it.
Caution
It is very important that
flame_on, or flamegraphs in general, not be enabled in production, because it messes with how function calls work and can slow down critical paths. It's currently scoped to not run whenMix.env()is:prod, and the dep is only installed for:dev. We need to make sure to keep it that way.Screenshots
How to test
Navigate to the Flame On pane in the dashboard and have fun!