Add compatibility with custom user models#13
Open
ProfessorLogout wants to merge 1 commit intomawassk:mainfrom
Open
Add compatibility with custom user models#13ProfessorLogout wants to merge 1 commit intomawassk:mainfrom
ProfessorLogout wants to merge 1 commit intomawassk:mainfrom
Conversation
mpirnat
added a commit
to mpirnat/django-ninja-apikey
that referenced
this pull request
Jul 8, 2023
Thanks to ProfessorLogout in mawassk#13 for this suggestion.
|
I forked the project to implement some features that I needed. Feel free to submit your PR there. Source: https://github.com/lucasrcezimbra/ninja-api-key |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom user model the
usernamefield may not exist on the model.Django solves this by having a
get_usernamemethod on theUsermodel as documented here.Since this is already required for a working custom user model I think it would be great to adhere to the same interface.