Eliminate unnecessary bounds checks in hot paths#1381
Merged
Conversation
- Replace len(args[start:start+na]) > 0 with na > 0 to avoid slice bounds check - Use range loops instead of manual index loops for cols/decltype slices - Use range variable v.Ordinal instead of re-indexing args[i].Ordinal - Add bounds hint for decltype access in nextSyncLocked loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce bounds checks in performance-sensitive code paths by using range loops, avoiding redundant slice expressions, and adding compiler hints. Benchmarks show ~2-3% improvement in Rows/StmtRows/Params/Stmt benchmarks.