Skip to content

Add columns used to BestIndex callback, add missing index constraint op types.#1336

Closed
theimpostor wants to merge 2 commits intomattn:masterfrom
theimpostor:colsUsed
Closed

Add columns used to BestIndex callback, add missing index constraint op types.#1336
theimpostor wants to merge 2 commits intomattn:masterfrom
theimpostor:colsUsed

Conversation

@theimpostor
Copy link
Copy Markdown
Contributor

Fixes #1322, fixes #1323

@mattn
Copy link
Copy Markdown
Owner

mattn commented Mar 16, 2026

Could you please split this into two separate PRs?

  1. Adding the missing constraint op types (Constraint op types missing #1322)
  2. Adding colsUsed to BestIndex (vtable BestIndex callback missing colUsed input #1323)

The first one is a backwards-compatible change and can be merged right away. The second one is a breaking change to the VTab interface, so I'd like to review it separately.

@theimpostor
Copy link
Copy Markdown
Contributor Author

Split per review into #1379 for #1322 and #1378 for #1323.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vtable BestIndex callback missing colUsed input Constraint op types missing

2 participants