Remove redundant Save Theme button causing theme creation failures#36
Closed
Remove redundant Save Theme button causing theme creation failures#36
Conversation
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add settings screen to edit config file
Add settings screen with Command+, shortcut and ~/.PDV/settings storage
Feb 18, 2026
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot
AI
changed the title
Add settings screen with Command+, shortcut and ~/.PDV/settings storage
Add appearance and keyboard shortcuts tabs to settings
Feb 18, 2026
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot
AI
changed the title
Add appearance and keyboard shortcuts tabs to settings
Fix theme editor creating custom themes on every keystroke
Feb 19, 2026
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot
AI
changed the title
Fix theme editor creating custom themes on every keystroke
Add explicit theme save button and separate shortcuts storage
Feb 19, 2026
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot
AI
changed the title
Add explicit theme save button and separate shortcuts storage
Remove redundant Save Theme button causing theme creation failures
Feb 19, 2026
Owner
|
@copilot very briefly summarize what is added in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Themes failed to save when edited from the default "Dark" theme. The "Save Theme" button in the Appearance tab threw silent errors while a separate working implementation existed in the main Save handler.
Changes
Removed duplicate theme creation path:
handleSaveThemefunction and "Save Theme" button from AppearanceTabonSaveThemeprop,savingTheme, andsaveErrorstateUpdated user guidance:
Implementation
The main
handleSavealready correctly:window.pdv.themes.createCustom()The removed
handleSaveThemeduplicated this logic with bugs (requiredpendingThemeColorsupfront, causing failures when editing default theme). Keeping the working implementation eliminates the UX confusion and code duplication.Net: -100 lines
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.