Skip to content

Remove redundant Save Theme button causing theme creation failures#36

Closed
Copilot wants to merge 13 commits intodevelopfrom
copilot/add-settings-screen-feature
Closed

Remove redundant Save Theme button causing theme creation failures#36
Copilot wants to merge 13 commits intodevelopfrom
copilot/add-settings-screen-feature

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 18, 2026

Themes failed to save when edited from the default "Dark" theme. The "Save Theme" button in the Appearance tab threw silent errors while a separate working implementation existed in the main Save handler.

Changes

Removed duplicate theme creation path:

  • Deleted handleSaveTheme function and "Save Theme" button from AppearanceTab
  • Removed onSaveTheme prop, savingTheme, and saveError state
  • Consolidated to single save flow through main Settings handler

Updated user guidance:

  • Hint now reads: "Theme changes will be saved when you click 'Save' at the bottom"
  • Single Save button at dialog bottom handles both settings and theme creation

Implementation

The main handleSave already correctly:

  • Detects color/name modifications by comparing with base theme
  • Creates custom themes via window.pdv.themes.createCustom()
  • Persists theme name changes
  • Works for both default and selected themes

The removed handleSaveTheme duplicated this logic with bugs (required pendingThemeColors upfront, causing failures when editing default theme). Keeping the working implementation eliminates the UX confusion and code duplication.

Net: -100 lines


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 4 commits February 18, 2026 16:44
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot AI changed the title [WIP] Add settings screen to edit config file Add settings screen with Command+, shortcut and ~/.PDV/settings storage Feb 18, 2026
Copilot AI requested a review from matt-pharr February 18, 2026 16:55
Copilot AI and others added 4 commits February 18, 2026 23:32
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot AI changed the title Add settings screen with Command+, shortcut and ~/.PDV/settings storage Add appearance and keyboard shortcuts tabs to settings Feb 18, 2026
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot AI changed the title Add appearance and keyboard shortcuts tabs to settings Fix theme editor creating custom themes on every keystroke Feb 19, 2026
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot AI changed the title Fix theme editor creating custom themes on every keystroke Add explicit theme save button and separate shortcuts storage Feb 19, 2026
Copilot AI and others added 2 commits February 19, 2026 00:38
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Co-authored-by: matt-pharr <25289941+matt-pharr@users.noreply.github.com>
Copilot AI changed the title Add explicit theme save button and separate shortcuts storage Remove redundant Save Theme button causing theme creation failures Feb 19, 2026
@matt-pharr
Copy link
Copy Markdown
Owner

@copilot very briefly summarize what is added in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants