Open
Conversation
Author
|
@bwindels can we merge this? |
Member
|
@laurencegill this seems like it'll break Netlify deploys? Surely it shouldn't be done by the build script unless its happening for CFP? |
Member
|
Not sure why this repo uses Netlify & CFP for PR previews, likely Netlify can just be disabled a this point |
Author
I'm not sure if Netlify is still used or not, if not we can disable it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoC - disable the default behaviour of adding
access-control-allow-origin: *to pages sitesEnable ACAO only for static
/images/Available at:
https://cf-pages-headers.matrix-to-asy.pages.dev/
The deployment mechanism probably needs looking at (writing into the build.js file).
Reference:
https://github.com/vector-im/sre-internal/issues/2606