Skip to content

[datakit] Verify materialized fuzzy clusters - #8725

Open
ravwojdyla-agent wants to merge 1 commit into
rav/fuzzy-cluster-textfrom
rav/fuzzy-cluster-verifier
Open

[datakit] Verify materialized fuzzy clusters#8725
ravwojdyla-agent wants to merge 1 commit into
rav/fuzzy-cluster-textfrom
rav/fuzzy-cluster-verifier

Conversation

@ravwojdyla-agent

Copy link
Copy Markdown
Contributor
  • require a complete cluster-text artifact before verification starts
  • solve grouped clusters in bounded distributed map tasks and route sparse markers back to normalized shards
  • write the existing verified-marker Parquet schema with stable representative source keys
  • keep truncated documents and exclude them from representative selection
  • distinguish pipeline and cluster marker producers while preserving the common store input contract
  • stacked on [datakit] Materialize fuzzy-duplicate cluster text #8724

@ravwojdyla-agent ravwojdyla-agent added the agent-generated Created by automation/agent label Aug 27, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 923f19334a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +176 to +178
yield from _solve_batch(pending)
pending = []
pending_chars = 0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve representatives across mid-cluster flushes

When a materialized cluster exceeds MAXIMUM_CLUSTER_CHARS (256 MiB), this branch solves the longest-sorted prefix and then discards all of its surviving representatives before processing the remainder. Consequently, shorter documents in later chunks are never compared with the cluster's longest representatives, producing false negatives and potentially retaining multiple copies that find_duplicates would remove if given the whole cluster. The memory guard must preserve earlier representatives across flushes or explicitly repartition the cluster before verification.

Useful? React with 👍 / 👎.

Solve grouped cluster text in distributed map tasks and route sparse duplicate markers back to normalized shards. Record the cluster rule in the shared verified-marker artifact contract.
@ravwojdyla
ravwojdyla force-pushed the rav/fuzzy-cluster-text branch from dc992a8 to cabd5d8 Compare August 27, 2026 12:49
@ravwojdyla
ravwojdyla force-pushed the rav/fuzzy-cluster-verifier branch from 923f193 to 1781294 Compare August 27, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-generated Created by automation/agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants