-
Notifications
You must be signed in to change notification settings - Fork 4
Changed so pr can now take in URL as well as pr number. #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ttran428
wants to merge
90
commits into
machine-shop:master
Choose a base branch
from
ttran428:pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 85 commits
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
7154e1b
changed to toml
10b8fde
inserted changes from sera
61c6ad0
used toml with comments
27fe7aa
refactored code
34a28b9
updated changes
78ff0f9
started documentation
af87d2c
added example of code ran in terminal
6c73f8b
added tools
a323c90
changed requirements
ffbd8e9
function mispelling fixed
c533dbf
changed file path and refactored
7e71972
added documentation but to wrong branch
b210743
Merge branch 'push' into documentation
dd7d585
Fixed crlf issue (hopefully)
ea818c5
Merge branch 'master' into push
stefanv dfee42a
Clarify error message on missing token & fix invalid makeFile call.
stefanv c0f5d58
made some minor changes
f82ffad
testing
15300c1
second test
5268d5a
trying clone
2ad6540
trying clone 2
d3fe459
trying clone 3
31a4bcc
again
812d522
trying again
988b3c6
test file
2a1e2dd
new test
7521448
trying agian
87f8219
hello
a03ecea
changed to https
e305cfc
deleted build
d4ce7e0
fixed opening files format
cc8f2bc
deleted docs folder
354c60f
fixed tests since added to wrong branch
34b045c
minor
f26026c
local tests work
570cf2a
changed traivs
c38247f
style changes
0e8f2f2
deleted testing file
22a9d9e
changes
37e47bd
changed to sera's code
4732510
made template for no disccusion
abf7478
trying to deploy
13d07f9
added in key
1265f9f
docs
368f173
new docs
214c60e
added sphinx to rquirements
0fdc94d
trying to get right path
abfe5f8
Delete github_deploy_key_ttran428_oss_devkit.enc
ttran428 d5650b8
try again
4d74218
merged
8db6e51
Merge branch 'master' of github.com:ttran428/oss_devkit
2e4879a
again
d1b65cd
added environment
5a2b97d
new pages
b687d70
added travis file
d80c7b9
deleted build
373bbd4
deleted info in build
e7cb367
changed format and updated how to find hot prs
26b2e91
add templates
2374eb6
new info displayed but page not displaying
670ae29
debugged functions
5fb25b0
fixed bugs with priorityqueue
9dc9443
fixed oldest
acdb899
fixed structure
abf9469
added git hub render
ab83932
deleted other files
b212b8c
fixed README
418a162
formatting changes
f758564
fixed args
ttran428 9e9741d
fixed to flake8 format
b50da92
fixed format for push
ttran428 f8c8bd6
updated docs with image and render
ttran428 5ed7992
Merge branch 'master' of github.com:machine-shop/oss_devkit into docu…
ttran428 3b6856c
added newline at end of file
ttran428 943f18a
Merge branch 'documentation'
ttran428 79fd1f7
authentificated requests
ttran428 961e5d5
merged
ttran428 59628b6
cchanged formatting
ttran428 5799bb2
allowed push to take url
ttran428 84a63e9
finds info using github object
ttran428 5fcc3e9
allows to pull pr by url
ttran428 1becefe
fixed small bugs
ttran428 0fd5122
merged conflicts
ttran428 f1ddf19
style changes
ttran428 9172836
deleted travis key
ttran428 e71d65a
fixed minor error with url parsing for pr
ttran428 b254f66
Added comments to the command for clarity
ttran428 ab5ef22
changed to regex
ttran428 39c2f4f
took out print statements
ttran428 b814a5f
Merge branch 'master' into pr
ttran428 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,4 @@ pyyaml | |
| click | ||
| toml | ||
| requests | ||
| jinja2 | ||
| jinja2 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this code doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It checks if the argument supplied is an integer (so either the pr number(i.e. 4) or the url(e.g. #35)) so that it knows whether to take it as an integer or to find the pr number inside the url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It changed the url I inputted into my comment. But like if the user inputted instead of '30', they inputted 'https://github.com/machine-shop/oss_devkit/pull/ 30'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I suggest adding comments to both branches of the "if", saying what you're expecting in each branch. This will help future developers see what you're doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments.