fix: avoid undefined array key warning in RefundProcessor::doOnSuccess#12
Open
rv-garnier wants to merge 1 commit into
Open
fix: avoid undefined array key warning in RefundProcessor::doOnSuccess#12rv-garnier wants to merge 1 commit into
rv-garnier wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
RefundProcessor::doOnSuccess, the loop iterates over all payments of the order and unconditionally reads themonetico_trans_uuidkey fromgetDetails():An order can legitimately contain payments without this key (cancelled retry payments with empty details, payments from other gateways, anonymized payments, etc.). On PHP 8+ this triggers
Warning: Undefined array key "monetico_trans_uuid", which is converted to anErrorExceptionby Symfony's error handler — interrupting the loop before the matching Monetico payment can be found. As a result, the SyliusPaymentstate machine transition torefundedis never applied, even though the refund itself succeeded on Monetico's side, leaving the local payment record desynchronized.Fix
Use the null-coalescing operator to safely read the key:
Minimal, behavior-preserving change: payments without the key simply don't match and the loop continues.