PEP8 module names and pass N999 lint#11
Merged
hcallahan-lowrisc merged 26 commits intolowRISC:masterfrom Sep 10, 2025
Merged
Conversation
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
…uncher.factory Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
…base Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
…cher.local Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
…er.lsf Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
…r.nc Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
…er.sge Also move the Sun Grid Engine modules into the same dir to make it easier to find dependencies. These are not useful for wider DVSim functionality, so keeping them grouped together helps tidy things up. Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
…cher.slurm Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
machshev
requested review from
andreaskurth,
hcallahan-lowrisc,
mkj121,
nbdd0121 and
vogelpi
mkj121
suggested changes
Sep 9, 2025
mkj121
left a comment
mkj121
left a comment
There was a problem hiding this comment.
Some line spaces are missing, I think, from the init.py files
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
machshev
force-pushed
the
standard_module_names
branch
from
dc2e03f to
a7ddbc5
Compare
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
mkj121
approved these changes
Sep 10, 2025
hcallahan-lowrisc
approved these changes
Sep 10, 2025
Contributor
hcallahan-lowrisc
left a comment
hcallahan-lowrisc
left a comment
There was a problem hiding this comment.
LGTM! Thanks @machshev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to make the module names PEP8 compliant and pass the N999 lint check. There should not be any functional changes in this PR.
The other reason for doing this is that it adds some more structure to the source code, making it easier to find things. Before it was quite flat, and the top level crowded.