Skip to content

Fix incorrect array slicing parameters#258

Open
raimannma wants to merge 2 commits intomasterfrom
fix_incorrect_array_slicing
Open

Fix incorrect array slicing parameters#258
raimannma wants to merge 2 commits intomasterfrom
fix_incorrect_array_slicing

Conversation

@raimannma
Copy link
Copy Markdown
Member

@raimannma raimannma commented Dec 16, 2020

REBASED VERSION from steven nguyen

Ugh I keep getting this error. I put in so many layers!!!!
image

I looked at the code to try to do it myself but I ended up finding a bug instead.

Code changed:
Array.slice(0, -1) instead of Array.slice(Start at length - 1)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice

Ugh I keep getting this error whyyy. I put in 100 LAYERS! 

Well because of a bug.
Array.slice(0, -1) instead of Array.slice(Start at length - 1)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice
@raimannma
Copy link
Copy Markdown
Member Author

@christianechevarria Is it possible to add a bit tolerance to coveralls check?

@icecream17
Copy link
Copy Markdown

I just realized it might be better to do Array.pop() instead of Array.slice(0, -1)

Comment thread src/architecture/architect.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🕷️ bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants