Persist negotiated splice candidates on reload#4653
Open
wpaulino wants to merge 1 commit into
Open
Conversation
Prior to supporting RBF, we would avoid persisting `FundedChannel::pending_splice` when there was a pending funding negotiation that could not be resumed on channel reestablishment. With the addition of RBF support, this would cause our previously negotiated splices (but still pending) to be dropped unintentionally.
|
👋 Thanks for assigning @jkczyz as a reviewer! |
Collaborator
|
No issues found. I thoroughly reviewed every hunk of the diff, including:
|
jkczyz
reviewed
Jun 2, 2026
Comment on lines
+3057
to
+3069
| let contributions = if contributions_len == 0 { | ||
| None | ||
| } else { | ||
| Some(Iterable(self.pending_funding.contributions.iter().take(contributions_len))) | ||
| }; | ||
| write_tlv_fields!(writer, { | ||
| (1, funding_negotiation, upgradable_option), | ||
| (3, self.pending_funding.negotiated_candidates, required_vec), | ||
| (5, self.pending_funding.sent_funding_txid, option), | ||
| (7, self.pending_funding.received_funding_txid, option), | ||
| (8, self.pending_funding.last_funding_feerate_sat_per_1000_weight, option), | ||
| (10, contributions, option), | ||
| }); |
Contributor
There was a problem hiding this comment.
Could we simplify this using a slice?
(10, self.pending_funding.contributions[..contributions_len], optional_vec),| .pending_splice | ||
| .as_ref() | ||
| .filter(|pending_splice| { | ||
| !reset_pending_splice_state || !pending_splice.negotiated_candidates.is_empty() |
Contributor
There was a problem hiding this comment.
Consider using !self.pending_funding().is_empty() to mirror the logic from reset_pending_splice_state.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to supporting RBF, we would avoid persisting
FundedChannel::pending_splicewhen there was a pending funding negotiation that could not be resumed on channel reestablishment. With the addition of RBF support, this would cause our previously negotiated splices (but still pending) to be dropped unintentionally.Fixes the following payloads from #4636: