fix(ast): guard all unsafe .at() type lookups against missing keys - #171
Merged
Conversation
wizardengineer
changed the title
wizardengineer
force-pushed
the
fix/safe-type-lookup
branch
from
March 18, 2026 10:14
2b88c2f to
d6df5ff
Compare
kyle-elliott-tob
approved these changes
Apr 14, 2026
Adds GetSerializedType(key) to TypeBuilder that returns an empty QualType with a warning log instead of throwing std::out_of_range when the key is missing. Migrates 13 .at() call sites across ASTConsumer, FunctionBuilder, OperationBuilder, and OperationStmt. Supersedes #171 (rebased onto current main after the Pascal-case rename in #148). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wizardengineer
force-pushed
the
fix/safe-type-lookup
branch
from
April 17, 2026 08:16
8251a0d to
7e65495
Compare
Contributor
Author
|
once the CI finishes, I'll merge it. Thanks for the review @kyle-elliott-tob ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add get_serialized_type() safe lookup wrapper to TypeBuilder that returns an empty QualType instead of throwing std::out_of_range when a type key is missing. Logs a warning for debugging.
Migrates all 13 call sites across ASTConsumer, FunctionBuilder, OperationBuilder, and OperationStmt from:
type_builder().get_serialized_types().at(key)
to:
type_builder().get_serialized_type(key)
Fixes #145