Fix Perm16::random#66
Merged
james-d-mitchell merged 1 commit intolibsemigroups:mainfrom Nov 20, 2025
Merged
Conversation
Joseph-Edwards
approved these changes
Nov 20, 2025
Contributor
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
There was a problem hiding this comment.
Thinks looks good to me, and the fix works on my machine too. I don't understand what's meant to happen if n>16 (undefined badness? perhaps we don't care) but that's not a concern for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #60. Previously a copy of the
Perm16inrandomwas converted to an array, then shuffled, then the originalPerm16was returned. I.e. the original non-shuffledPerm16was returned. This PR fixes this, so that the originalPerm16is not copied, but changed in place.