Regularize the various VFS seek implementations (attempt 2)#19151
Open
white-axe wants to merge 4 commits into
Open
Regularize the various VFS seek implementations (attempt 2)#19151white-axe wants to merge 4 commits into
white-axe wants to merge 4 commits into
Conversation
)" (libretro#18624) This reverts commit 5616e49.
…ek position in `retro_vfs_file_open_impl()`
…ad_overflow_test.c
Contributor
|
If this is going to cause issues in cores using vfs like the last time, any way to get ahead of the issue? The majority of the cores, including some upstream maintained ones like ppsspp now support vfs. Even dolphin has it (in the libretro fork though) |
Contributor
Author
|
It most likely won't cause issues in existing cores. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #18607 I attempted to address an inconsistency across different implementations of the libretro VFS seek function in libretro-common, but that was reverted due to causing issue #18619.
I have found out the cause of #18619: the function
retro_vfs_file_open_impl()assumes thatretro_vfs_file_seek_internal()returns the new position that the file was seeked to under some circumstances, but #18607 changed the behaviour ofretro_vfs_file_seek_internal()in such a way that it breaks the logic ofretro_vfs_file_open_impl(). I have fixed this in the third commit in this pull request.I also found another inconsistency in the seek implementation which I have fixed in the second commit in this pull request.