fix(tls): reject inbound connections that present no client certificate#1341
Merged
Conversation
Fixes libp2p#1340. Request client certificates on inbound TLS contexts, reject connections that present no certificate on the standard path, and align TLSHandshakeFailure with the central security exception hierarchy so TransportUpgrader surfaces SecurityUpgradeFailure. Preserve the AutoTLS broker bootstrap exception behind enable_autotls. Co-authored-by: Cursor <cursoragent@cursor.com>
Cover transport-level rejection, upgrader integration, and the AutoTLS primitive-exchange exception path. Co-authored-by: Cursor <cursoragent@cursor.com>
Build RTCIceServer objects in WebRTC helpers to satisfy mypy, use a valid generated certhash in the webrtc-direct multiaddr test, and apply ruff parenthesized with-statement formatting in TLS regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes #1340
Inbound TLS connections were accepted even when the remote peer sent no client certificate. The server silently assigned a synthetic placeholder Peer ID and returned a fully-formed
SecureSession, bypassing libp2p's mutual authentication requirement entirely.How was it fixed?
The fix addresses each of the failure layers:
enable_autotlsflag so it cannot be reached on a standard node.TLSHandshakeFailureextends the centralHandshakeFailuresoTransportUpgradersurfacesSecurityUpgradeFailureon rejection.Tests and docs
docs/tls-support.rstdocuments inbound mutual authentication and the AutoTLS bootstrap exception.To-Do