Chunking functionality#1556
Merged
pzelasko merged 9 commits intolhotse-speech:masterfrom Apr 16, 2026
Merged
Conversation
Signed-off-by: Nune <ntadevosyan@nvidia.com>
Signed-off-by: Nune <ntadevosyan@nvidia.com>
Signed-off-by: Nune <ntadevosyan@nvidia.com>
Signed-off-by: Nune <ntadevosyan@nvidia.com>
pzelasko
reviewed
Mar 20, 2026
Collaborator
pzelasko
left a comment
pzelasko
left a comment
There was a problem hiding this comment.
@nune-tadevosyan can we add unit tests for this as well?
Signed-off-by: Nune <ntadevosyan@nvidia.com>
…hotse into chunking_functionality
pzelasko
requested changes
Mar 23, 2026
| cut = _make_cut(duration=30.0) | ||
| result = list(cut.cut_into_windows_balanced(min_duration=30, max_duration=40)) | ||
| assert len(result) == 1 | ||
| assert result[0].id == cut.id |
Collaborator
There was a problem hiding this comment.
it should test strict equality not just id equality
| cut = _make_cut(duration=40.0) | ||
| result = list(cut.cut_into_windows_balanced(min_duration=30, max_duration=40)) | ||
| assert len(result) == 1 | ||
| assert result[0].id == cut.id |
Collaborator
There was a problem hiding this comment.
it should test strict equality not just id equality
| cut = _make_cut(duration=duration) | ||
| windows = list(cut.cut_into_windows_balanced(min_duration=30, max_duration=40, overlap=overlap)) | ||
|
|
||
| assert len(windows) >= 2 |
Collaborator
There was a problem hiding this comment.
it should test for an exact specific number of windows and specific start/duration values, the assertions are too flexible
| assert any(w_id.startswith("long-") for w_id in ids) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("num_jobs", [1, 2]) |
Collaborator
There was a problem hiding this comment.
we can remove this test, it'll be slow due to multiprocessing
Signed-off-by: Nune <ntadevosyan@nvidia.com>
pzelasko
previously approved these changes
Mar 23, 2026
Signed-off-by: Nune <ntadevosyan@nvidia.com>
pzelasko
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds dynamic chunking functionality for audio files and allows grouping it in the NeMo later