feat: improve error message for unknown attributes#14213
Open
0rca wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
0rca
force-pushed
the
av/4011-improve-error-message-1
branch
from
dd050ee to
094f0cd
Compare
0rca
changed the title
This PR improves error message for unknown attributes, including labels. Instead of "unknown attribute", the message how instructs the user to import their attributes/labels from a separate file. Closes leanprover#4011
0rca
force-pushed
the
av/4011-improve-error-message-1
branch
from
094f0cd to
7ddf6d5
Compare
0rca
changed the title
nomeata
reviewed
Jul 5, 2026
nomeata
left a comment
nomeata
left a comment
Collaborator
There was a problem hiding this comment.
Even if the attribute isn't usable in the file they are defined in, can we at least recognize that an attribute has been declared, to give that message only when it actually applies? Maybe with a new non persistent newly-declared-attribute env extension?
github-actions
Bot
added
the
mathlib4-nightly-available
leanprover-bot
added
the
builds-manual
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error message for unknown attributes, including labels. Instead of "unknown attribute", the message how instructs the user to define/import their attributes/labels in/from a separate file.
Closes #4011