Skip to content

perf: avoid spawning a new thread per worker output message #14185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: avoid spawning a new thread per worker output message #14185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 26 additions & 24 deletions src/Lean/Server/FileWorker.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ def setupImports

/- Worker initialization sequence. -/
section Initialization
def initializeWorker (doc : DocumentMeta) (o e : FS.Stream) (initParams : InitializeParams) (opts : Options)
partial def initializeWorker (doc : DocumentMeta) (o e : FS.Stream) (initParams : InitializeParams) (opts : Options)
: IO (WorkerContext × WorkerState) := do
let clientHasWidgets := initParams.initializationOptions?.bind (·.hasWidgets?) |>.getD false
let maxDocVersionRef ← IO.mkRef 0
Expand Down Expand Up @@ -500,30 +500,32 @@ section Initialization
elaboration tasks here. -/
mkLspOutputChannel maxDocVersion : IO (Std.Channel OutputMessage) := do
let chanOut ← Std.Channel.new
let _ ← chanOut.forAsync (prio := .dedicated) fun ⟨msg?, serialized⟩ => do
-- discard outdated notifications; note that in contrast to responses, notifications can
-- always be silently discarded
let version? : Option Int := do
match msg? with
| some (.notification "textDocument/publishDiagnostics" (some params)) =>
let params : PublishDiagnosticsParams ← fromJson? (toJson params) |>.toOption
params.version?
| some (.notification "$/lean/fileProgress" (some params)) =>
let params : LeanFileProgressParams ← fromJson? (toJson params) |>.toOption
params.textDocument.version?
| some (.notification "$/lean/ileanInfoUpdate" (some params))
| some (.notification "$/lean/ileanInfoFinal" (some params)) =>
let params : LeanIleanInfoParams ← fromJson? (toJson params) |>.toOption
some params.version
| _ => none
if let some version := version? then
if version < (← maxDocVersion.get) then
return

-- note that because of `server.reportDelayMs`, we cannot simply set `maxDocVersion` here
-- as that would allow outdated messages to be reported until the delay is over
o.writeSerializedLspMessage serialized |>.catchExceptions (fun _ => pure ())
-- we used to use `.forAsync (prio := .dedicated)` here but that creates a new thread *per
-- message*
let _ ← BaseIO.asTask (prio := .dedicated) (processChanMsg chanOut maxDocVersion)
return chanOut
processChanMsg (chanOut : Std.Channel OutputMessage) (maxDocVersion : IO.Ref Int) : BaseIO Unit := do
let ⟨msg?, serialized⟩ := (← chanOut.recv).get
-- discard outdated notifications; note that in contrast to responses, notifications can
-- always be silently discarded
let version? : Option Int := do
match msg? with
| some (.notification "textDocument/publishDiagnostics" (some params)) =>
let params : PublishDiagnosticsParams ← fromJson? (toJson params) |>.toOption
params.version?
| some (.notification "$/lean/fileProgress" (some params)) =>
let params : LeanFileProgressParams ← fromJson? (toJson params) |>.toOption

@Kha Kha Jun 26, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangentially, it would probably make sense to avoid the JSON roundtrip in at least this case at it happens so often

params.textDocument.version?
| some (.notification "$/lean/ileanInfoUpdate" (some params))
| some (.notification "$/lean/ileanInfoFinal" (some params)) =>
let params : LeanIleanInfoParams ← fromJson? (toJson params) |>.toOption
some params.version
| _ => none
if version?.all (· >= (← maxDocVersion.get)) then
o.writeSerializedLspMessage serialized |>.catchExceptions (fun _ => pure ())
-- note that because of `server.reportDelayMs`, we cannot simply set `maxDocVersion` here
-- as that would allow outdated messages to be reported until the delay is over
processChanMsg chanOut maxDocVersion

getImportClosure? (snap : Language.Lean.InitialSnapshot) : Array Name := Id.run do
let some snap := snap.result?
Expand Down
Loading