Skip to content

feat: Improvements to Elaboration of tensor expressions#1318

Merged
jstoobysmith merged 5 commits into
leanprover-community:masterfrom
jstoobysmith:ElabImprove
Jul 1, 2026
Merged

feat: Improvements to Elaboration of tensor expressions#1318
jstoobysmith merged 5 commits into
leanprover-community:masterfrom
jstoobysmith:ElabImprove

Conversation

@jstoobysmith

Copy link
Copy Markdown
Member

Two improvements to Elaboration of tensor expressions:

  • Terms of type Tensor S _ now no longer get a redundant toTensor inserted when they appear in tensor expressions.
  • Redundant permutations of indices (which trivially correspond to the identity) are no longer added.

co-authored with claude.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

@morrison-daniel morrison-daniel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@morrison-daniel morrison-daniel added the ready-to-merge This PR is approved and will be merged shortly label Jul 1, 2026
@morrison-daniel morrison-daniel self-assigned this Jul 1, 2026
@jstoobysmith jstoobysmith merged commit d192578 into leanprover-community:master Jul 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants