Skip to content

feat: Lemmas related to evaluating indices of tensors#1292

Merged
jstoobysmith merged 7 commits into
leanprover-community:masterfrom
jstoobysmith:EvaulationLemmas
Jul 2, 2026
Merged

feat: Lemmas related to evaluating indices of tensors#1292
jstoobysmith merged 7 commits into
leanprover-community:masterfrom
jstoobysmith:EvaulationLemmas

Conversation

@jstoobysmith

@jstoobysmith jstoobysmith commented Jun 26, 2026

Copy link
Copy Markdown
Member

Added lemmas related to the evaluation of indices of tensors.

Claude used for part of the proofs.

jstoobysmith and others added 3 commits June 26, 2026 11:41
Co-Authored-By: Claude <claude@users.noreply.github.com>
Co-Authored-By: Claude <claude@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

@jstoobysmith jstoobysmith requested a review from zhikaip June 26, 2026 13:41

@zhikaip zhikaip left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add more documentation to explain what evalT permT etc. are doing? I understand this is part of a larger refactor and maybe you want to do it at the end, so I've approved this for now

@jstoobysmith jstoobysmith added the awaiting-author A reviewer has asked the author a question or requested changes label Jun 28, 2026
jstoobysmith and others added 3 commits June 29, 2026 09:11
Co-Authored-By: Claude <claude@users.noreply.github.com>
@jstoobysmith jstoobysmith removed the awaiting-author A reviewer has asked the author a question or requested changes label Jun 29, 2026
@jstoobysmith

Copy link
Copy Markdown
Member Author

@zhikaip Made enough changes that this probably need another review before merging.

@jstoobysmith

Copy link
Copy Markdown
Member Author

Going to merge this now.

@jstoobysmith jstoobysmith merged commit b891322 into leanprover-community:master Jul 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants