Feat(icons): Added FilterAllIcon component#1600
Conversation
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new FilterNoneIcon component and exports it. The review feedback suggests simplifying the SVG element by removing redundant fill and fillOpacity attributes, as they are already handled by spreading props.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Kanishk Singh <kanishksingh763@gmail.com>
banana-three-join
left a comment
banana-three-join
left a comment
There was a problem hiding this comment.
The fill prop should be passed down to the path, not the SVG. You can add it back and give it the default green color being used in the other icons, as that's the standard within all of the icons being exported from Sistent.
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
|
@banana-three-join, I have addressed your feedback. |
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
kanishksingh23
changed the title
|
@Rajesh-Nagarajan-11, please review. |
Signed-off-by: Rajesh Nagarajan <139469505+Rajesh-Nagarajan-11@users.noreply.github.com>
|
@kanishksingh23 Since the default has been changed to fill none, you can instead remove the import of the previous color and import the default none instead. After that, it'll be good to merge. |
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
kanishksingh23
force-pushed
the
feat/filter-none-icon
branch
from
a14b23f to
aca8b06
Compare
|
@banana-three-join, I have removed the unused KEPPEL_GREEN_FILL import and updated it to DEFAULT_FILL_NONE. |
4 participants
Notes for Reviewers
This PR fixes #1599
Related: meshery/meshery#14157, meshery/meshery#19004
Signed commits