test: remove legacy storage key loader integration test#35225
Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom Apr 15, 2026
Merged
Conversation
dosubot
bot
added
the
size:XS
Contributor
Pyrefly DiffNo changes detected. |
asukaminato0721
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant legacy integration test for StorageKeyLoader now that equivalent coverage exists in the Testcontainers-based integration test suite (aligning with the ongoing migration in #32454).
Changes:
- Deleted
api/tests/integration_tests/factories/test_storage_key_loader.py(legacy integration test). - Relies on the existing Testcontainers equivalent at
api/tests/test_containers_integration_tests/factories/test_storage_key_loader.py.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api/tests/integration_tests/factories/test_storage_key_loader.py(375 lines)api/tests/test_containers_integration_tests/factories/test_storage_key_loader.pyTest plan
Part of #32454