fix(langsmith): SmithDB Beacon env compatible with BYOC commonEnv - #984
Open
ericdong-langchain wants to merge 1 commit into
Open
fix(langsmith): SmithDB Beacon env compatible with BYOC commonEnv#984ericdong-langchain wants to merge 1 commit into
ericdong-langchain wants to merge 1 commit into
Conversation
Skip duplicate commonEnv keys so PHONE_HOME_ENABLED from the data plane does not fail Helm, and treat langsmith_license_key as optional when using an existing secret. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commonEnv/smithdb.commonEnvkeys that SmithDB templates already set, so BYOCPHONE_HOME_ENABLEDno longer duplicates Beacon env and failsdetectDuplicates.config.existingSecretNameis set,LANGSMITH_LICENSE_KEYis optional. BYOC authenticates Beacon withDATA_PLANE_JWT_SECRETand does not store a license key.v16 backport: follow-up PR against
v16-stable.Test plan
helm unittest charts/langsmith -f charts/langsmith/tests/langsmith_smithdb_test.yamlPHONE_HOME_ENABLEDincommonEnv+BEACON_LOGGING_ENABLEDinsmithdb.commonEnv) render without duplicate-key failure.Made with Cursor