Skip to content

Warnings addressing #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MateuszKubuszok merged 3 commits into from
May 1, 2026
Merged

Warnings addressing #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b44154d
Eliminate all warnings, enforce -Werror on deprecations
MateuszKubuszok May 1, 2026
0d4d3f6
Mark deleted deprecated files as skip in migration database
MateuszKubuszok May 1, 2026
d6f49a8
Remove misleading @deprecated scaladoc tags from ScrollPane and Conta…
MateuszKubuszok May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .rescale/data/migration.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,11 +621,11 @@ com/kotcrab/vis/ui/util/adapter/AbstractListAdapter.java ai_converted extension
com/kotcrab/vis/ui/util/dialog/Dialogs.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/util/ColorUtils.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/util/OsUtils.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/layout/VerticalFlowGroup.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/layout/VerticalFlowGroup.java skip extension 2026-05-01 Deprecated class deleted, FlowGroup is the replacement vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/layout/GridGroup.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/layout/FlowGroup.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/layout/FloatingGroup.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/layout/HorizontalFlowGroup.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/layout/HorizontalFlowGroup.java skip extension 2026-05-01 Deprecated class deleted, FlowGroup is the replacement vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/layout/DragPane.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/building/CenteredTableBuilder.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
com/kotcrab/vis/ui/building/GridTableBuilder.java ai_converted extension 2026-03-31 vis-ui 820300c86a1bd907404217195a9987e5c66d2220 2026-04-28
Expand Down Expand Up @@ -661,7 +661,7 @@ com/github/tommyettinger/textra/TextraDialog.java ai_converted extension 2026-0
com/github/tommyettinger/anim8/FastGif.java ai_converted extension 2026-03-31 anim8-gdx 38634cefd749a9a8af4534ca285c8e72437fe181 2026-04-28
com/github/tommyettinger/anim8/FastPNG.java ai_converted extension 2026-03-31 anim8-gdx 38634cefd749a9a8af4534ca285c8e72437fe181 2026-04-28
com/github/tommyettinger/anim8/FastPNG8.java ai_converted extension 2026-03-31 anim8-gdx 38634cefd749a9a8af4534ca285c8e72437fe181 2026-04-28
com/github/tommyettinger/anim8/FastAPNG.java ai_converted extension 2026-03-31 anim8-gdx 38634cefd749a9a8af4534ca285c8e72437fe181 2026-04-28
com/github/tommyettinger/anim8/FastAPNG.java skip extension 2026-05-01 Deprecated wrapper deleted, AnimatedPNG is the replacement anim8-gdx 38634cefd749a9a8af4534ca285c8e72437fe181 2026-04-28
com/github/tommyettinger/anim8/FastPalette.java ai_converted extension 2026-03-31 anim8-gdx 38634cefd749a9a8af4534ca285c8e72437fe181 2026-04-28
com/github/tommyettinger/anim8/QualityPalette.java ai_converted extension 2026-03-31 anim8-gdx 38634cefd749a9a8af4534ca285c8e72437fe181 2026-04-28
com/github/tommyettinger/colorful/cielab/ColorfulSprite.java ai_converted extension 2026-03-31 colorful-gdx e4a5fd960eef746ca5aa826063432fb79666d74f 2026-04-28
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ lazy val `sge-jvm-platform-android` = (project in file("sge-jvm-platform/android
IO.createDirectory(cacheDir)
if (!aarFile.exists()) {
log.info(s"Downloading PanamaPort AAR from $aarUrl")
val in = new java.net.URL(aarUrl).openStream()
val in = new java.net.URI(aarUrl).toURL.openStream()
try { IO.transfer(in, aarFile) }
finally { in.close() }
}
Expand Down
1 change: 0 additions & 1 deletion sge-build/src/main/scala/sge/sbt/SgePlugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ object SgePlugin extends AutoPlugin {
"-Wrecurse-with-default",
"-Wenum-comment-discard",
"-Wunused:imports,privates,locals,patvars,nowarn",
"-Wconf:cat=deprecation:info",
// Kindlings macro derivation timeout — raised for Rosetta x86_64 emulation
// where macro expansion is ~3x slower than native ARM64.
"-Xmacro-settings:jsoniterDerivation.timeout=30s",
Expand Down
62 changes: 0 additions & 62 deletions sge-extension/anim8/src/main/scala/sge/anim8/FastAPNG.scala
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions sge-extension/freetype/src/main/scala/sge/graphics/g2d/freetype/FreetypeFontLoader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ import sge.utils.{ DynamicArray, Nullable }
*/
class FreetypeFontLoader(resolver: FileHandleResolver)(using Sge) extends AsynchronousAssetLoader[BitmapFont, FreetypeFontLoader.FreeTypeFontLoaderParameter](resolver) {

@scala.annotation.nowarn("msg=deprecated") // null check — parameter arrives from AssetManager which may pass null
override def loadAsync(
manager: AssetManager,
fileName: String,
Expand All @@ -49,7 +48,6 @@ class FreetypeFontLoader(resolver: FileHandleResolver)(using Sge) extends Asynch
if (parameter == null)
throw new RuntimeException("FreetypeFontParameter must be set in AssetManager#load to point at a TTF file!")

@scala.annotation.nowarn("msg=deprecated") // null check — parameter arrives from AssetManager which may pass null
override def loadSync(
manager: AssetManager,
fileName: String,
Expand Down
1 change: 1 addition & 0 deletions sge-extension/gltf/src/main/scala/sge/gltf/data/geometry/GLTFMorphTarget.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ import scala.collection.mutable.HashMap
/** A morph target is a map of attribute names to accessor indices. In the original Java, this extends ObjectMap and implements Json.Serializable; in SGE we use a simple HashMap since SGE uses
* jsoniter-scala, not LibGDX Json.
*/
@scala.annotation.nowarn("msg=inheritance from class HashMap.*is deprecated")
class GLTFMorphTarget extends HashMap[String, Int]
4 changes: 2 additions & 2 deletions sge-extension/gltf/src/main/scala/sge/gltf/exporters/GLTFBinaryExporter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import sge.graphics.glutils.FrameBuffer
import sge.gltf.data.data.{ GLTFBuffer, GLTFBufferView }
import sge.gltf.data.texture.GLTFImage
import sge.gltf.loaders.exceptions.{ GLTFRuntimeException, GLTFUnsupportedException }
import sge.utils.{ Nullable, ScreenUtils }
import sge.utils.Nullable

private[exporters] class GLTFBinaryExporter(
private val folder: FileHandle,
Expand Down Expand Up @@ -140,7 +140,7 @@ private[exporters] class GLTFBinaryExporter(
batch.begin()
batch.draw(texture, 0, 0, 1, 1, 0, 0, 1, 1)
batch.end()
val pixmap = ScreenUtils.getFrameBufferPixmap(Pixels(0), Pixels(0), texture.width, texture.height)
val pixmap = Pixmap.createFromFrameBuffer(Pixels(0), Pixels(0), texture.width, texture.height)
fbo.end()
batch.close()
fbo.close()
Expand Down
19 changes: 3 additions & 16 deletions sge-extension/gltf/src/main/scala/sge/gltf/scene3d/lights/SpotLightEx.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,26 +34,13 @@ class SpotLightEx extends SpotLight {
override def set(copyFrom: SpotLight): SpotLight =
copyFrom match {
case ex: SpotLightEx =>
set(
copyFrom.color,
copyFrom.position,
copyFrom.direction,
copyFrom.intensity,
copyFrom.cutoffAngle,
copyFrom.exponent,
ex.range
)
super.set(copyFrom.color, copyFrom.position, copyFrom.direction, copyFrom.intensity, copyFrom.cutoffAngle, copyFrom.exponent)
this.range = ex.range
this
case _ =>
set(copyFrom.color, copyFrom.position, copyFrom.direction, copyFrom.intensity, copyFrom.cutoffAngle, copyFrom.exponent)
}

@deprecated("use setRad or setDeg instead", "gdx-gltf")
def set(color: Color, position: Vector3, direction: Vector3, intensity: Float, cutoffAngle: Float, exponent: Float, range: Nullable[Float]): SpotLightEx = {
super.set(color, position, direction, intensity, cutoffAngle, exponent)
this.range = range
this
}

def setRad(color: Color, position: Vector3, direction: Vector3, intensity: Float, outerConeAngleRad: Float, innerConeAngleRad: Float, range: Nullable[Float]): SpotLightEx = {
if (color != null) this.color.set(color) // @nowarn — inherited API allows null
if (position != null) this.position.set(position) // @nowarn — inherited API allows null
Expand Down
4 changes: 2 additions & 2 deletions sge-extension/gltf/src/main/scala/sge/gltf/scene3d/utils/IBLBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ import sge.graphics.glutils.{ FrameBuffer, FrameBufferCubemap, ShaderProgram, Sh
import sge.graphics.glutils.ShapeRenderer.ShapeType
import sge.graphics.Pixmap
import sge.math.{ Matrix4, Vector3 }
import sge.utils.{ DynamicArray, Nullable, ScreenUtils, SgeError }
import sge.utils.{ DynamicArray, Nullable, SgeError }

class IBLBuilder private (using sge: Sge) extends AutoCloseable {

Expand Down Expand Up @@ -164,7 +164,7 @@ class IBLBuilder private (using sge: Sge) extends AutoCloseable {
renderGradientForSide(side, blur)
renderLightsForSide(side, false)

maps(index) = ScreenUtils.getFrameBufferPixmap(Pixels.zero, Pixels.zero, Pixels(size), Pixels(size))
maps(index) = Pixmap.createFromFrameBuffer(Pixels.zero, Pixels.zero, Pixels(size), Pixels(size))
index += 1
s += 1
}
Expand Down
Loading
Loading