add openSUSE Leap 16 handling by dirkmueller · Pull Request #417 · kubevirt/containerdisks

dirkmueller · 2025-10-15T20:05:45Z

What this PR does / why we need it:

openSUSE Leap has recently released it's newest stable release 16.0, which has a slightly different url layout.

kubevirt-bot · 2025-10-15T20:05:54Z

Hi @dirkmueller. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot · 2025-10-15T20:05:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lyarwood for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

0xFelix

Thanks for the PR! Looking great except for a few comments.

0xFelix · 2025-10-16T07:13:30Z

+				common.DefaultInstancetypeEnv: "u1.medium",
+				common.DefaultPreferenceEnv:   "opensuse.leap",


I wonder if these could work on aarch64 too?

The preference set a minimum of 1 cpu and 2GiB. I'm not able to find the minimum requirements for aarch64. @dirkmueller, could you please check if arm version meets this minimum hardware requirements too?

I don't think it is officially documented anywhere, but I think that would work. I've started very minimal VMs with that configuration.

0xFelix · 2025-10-16T07:16:32Z

/release-note-none

jcanocan · 2025-10-27T13:58:12Z

@dirkmueller ping

dirkmueller · 2025-10-27T22:43:26Z

@dirkmueller ping

thanks for the reminder, this fell off the list

jcanocan · 2025-10-28T07:52:53Z

@dirkmueller ping

thanks for the reminder, this fell off the list

Thanks to you for your contribution!
/lgtm

ksimon1 · 2025-10-30T08:25:21Z

/retest

Signed-off-by: Dirk Müller <dmueller@suse.com>

kubevirt-bot · 2025-10-30T08:30:06Z

@dirkmueller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-containerdisks-pipeline-opensuse-leap	`466c25d`	link	true	`/test pull-containerdisks-pipeline-opensuse-leap`
pull-containerdisks-pipeline-centos-stream-9-s390x	`466c25d`	link	true	`/test pull-containerdisks-pipeline-centos-stream-9-s390x`
pull-containerdisks-test	`466c25d`	link	true	`/test pull-containerdisks-test`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kubevirt-bot · 2025-10-30T08:30:32Z

New changes are detected. LGTM label has been removed.

dirkmueller · 2025-10-30T08:32:55Z

ok, so ssh login to leap 16.0 fails, I need to take a look at that..

kubevirt-bot · 2026-01-28T09:28:00Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

dirkmueller · 2026-02-02T11:12:14Z

/remove-lifecycle stale

I'll work on this, just had other priorities so far.

kastl-ars · 2026-02-13T14:13:41Z

@dirkmueller I could successfully build a containerdisk manually using the Leap 16.0 image:

https://quay.io/repository/kastl-atvantage/kubevirt-containerdisk-opensuse-leap-16.0

FROM scratch
ADD --chown=107:107 \
        https://download.opensuse.org/distribution/leap/16.0/appliances/Leap-16.0-Minimal-VM.x86_64-Cloud.qcow2 \
        /disk/

This worked fine and I could log in using the VNC console and SSH (via virtctl ssh).

Anything I can help out with?

kubevirt-bot · 2026-03-11T14:06:34Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 15, 2025

dirkmueller force-pushed the leap16 branch from 4b1e172 to 2d7b62b Compare October 15, 2025 20:05

kubevirt-bot requested review from codingben and ksimon1 October 15, 2025 20:05

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 15, 2025

dirkmueller force-pushed the leap16 branch from 2d7b62b to f82d642 Compare October 15, 2025 20:06

sourcery-ai Bot reviewed Oct 15, 2025

View reviewed changes

dirkmueller force-pushed the leap16 branch from f82d642 to a3713a9 Compare October 15, 2025 20:07

0xFelix reviewed Oct 16, 2025

View reviewed changes

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 16, 2025

dirkmueller force-pushed the leap16 branch from a3713a9 to 466c25d Compare October 27, 2025 22:42

kubevirt-bot assigned jcanocan Oct 28, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025

add openSUSE Leap 16 handling

5c14efb

Signed-off-by: Dirk Müller <dmueller@suse.com>

dirkmueller force-pushed the leap16 branch from 466c25d to 5c14efb Compare October 30, 2025 08:30

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025

dirkmueller marked this pull request as draft October 30, 2025 08:33

kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2026

kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 2, 2026

0xFelix mentioned this pull request Feb 10, 2026

Adding openSUSE Leap 16.0 #477

Closed

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2026

		common.DefaultInstancetypeEnv: "u1.medium",
		common.DefaultPreferenceEnv: "opensuse.leap",

Conversation

dirkmueller commented Oct 15, 2025

Uh oh!

kubevirt-bot commented Oct 15, 2025

Uh oh!

kubevirt-bot commented Oct 15, 2025

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

0xFelix left a comment

Choose a reason for hiding this comment

Uh oh!

0xFelix Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

jcanocan Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

dirkmueller Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

0xFelix commented Oct 16, 2025

Uh oh!

jcanocan commented Oct 27, 2025

Uh oh!

dirkmueller commented Oct 27, 2025

Uh oh!

jcanocan commented Oct 28, 2025

Uh oh!

ksimon1 commented Oct 30, 2025

Uh oh!

kubevirt-bot commented Oct 30, 2025

Uh oh!

kubevirt-bot commented Oct 30, 2025

Uh oh!

dirkmueller commented Oct 30, 2025

Uh oh!

kubevirt-bot commented Jan 28, 2026

Uh oh!

dirkmueller commented Feb 2, 2026

Uh oh!

kastl-ars commented Feb 13, 2026

Uh oh!

kubevirt-bot commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants