Skip to content

frontend: OauthPopup: Fix typos and use console.error#5054

Open
NAME-ASHWANIYADAV wants to merge 1 commit intokubernetes-sigs:mainfrom
NAME-ASHWANIYADAV:fix/oauthpopup-typo
Open

frontend: OauthPopup: Fix typos and use console.error#5054
NAME-ASHWANIYADAV wants to merge 1 commit intokubernetes-sigs:mainfrom
NAME-ASHWANIYADAV:fix/oauthpopup-typo

Conversation

@NAME-ASHWANIYADAV
Copy link
Copy Markdown

Fixes #5053

Summary

Fix two error catch blocks in OauthPopup that had the typo "occured" (should be "occurred") and were using console.log instead of console.error for error conditions.

Changes

  • Fix typo: "occured" → "occurred" in both error messages
  • Change console.log to console.error for proper error severity
  • Capitalize error messages consistently

Steps to Test

  1. Trigger OIDC auth flow that opens the OAuth popup
  2. Open browser DevTools → Console → filter by "Errors"
  3. Verify error messages appear correctly if the popup fails

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NAME-ASHWANIYADAV
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2026
@NAME-ASHWANIYADAV
Copy link
Copy Markdown
Author

/assign @illume

@NAME-ASHWANIYADAV
Copy link
Copy Markdown
Author

@illume Hi, could you please review this whenever you have some free time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OauthPopup: Typo "occured" and incorrect log level in error handlers

3 participants