docs(aws): document access key env vars for AWS provider#6201
docs(aws): document access key env vars for AWS provider#6201mjfxjas wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @mjfxjas! |
|
Hi @mjfxjas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks for the guidance. This is a docs-only change for AWS credential env var guidance.\n\nCould a maintainer please review and run ? |
|
Correction: could a maintainer please run /ok-to-test on this PR? Thanks! |
|
Hi. Thanks for a pull request. I'm not sure if this is something I could recommend doing. Hence w8 for other revewers. |
|
Daily check-in (2026-02-19): docs change is ready from my side. EasyCLA is green; tide is still pending and the ok-to-test approvals show skipped. Is there any maintainer action I should take (or anything to adjust) to help this move forward? |
|
Thanks for the feedback. My intent is strictly to document currently supported AWS credential env vars (not to recommend any insecure flow). If you’d like, I can narrow wording further to emphasize standard provider behavior and avoid implying preferred auth patterns. |
|
Friendly follow-up. Checking if any additional changes are needed from my side. CLA is green and I am happy to make wording or placement adjustments if maintainers prefer a different approach for documenting AWS env vars. |
|
We are w8 for other reviewers, this has no ETA. The approach provided here is least secure. We potentially could add it to docs, but we need to provide best practice/recomendation in such case. Current approach (this is missing, maybe worh adding) In the proposed approach when secret is mounted in the way The secret is still visible to:
For AWS specifically, best practice and recomended hierarchy:
Env (5) vars vs mounted (4) files doesn’t really matter — they’re both:
When to use
|
|
Asked AI to create table
|
|
@mjfxjas Do you think you can rework your PR to explain to the user the risk outlined by @ivankatliarchuk? |
Summary
This PR documents AWS credential environment variable support that is currently functional but under-documented.
Changes
AWS_ACCESS_KEY_IDAWS_SECRET_ACCESS_KEYAWS_SESSION_TOKEN(optional)AWS_REGION/AWS_DEFAULT_REGIONWhy
Issue #5265 reports this as missing from docs. This makes AWS auth paths clearer for users running external-dns in non-IRSA contexts.
Closes #5265