:warning: Standardize flavor in OpenStackMachine by nikParasyr · Pull Request #3087 · kubernetes-sigs/cluster-api-provider-openstack

nikParasyr · 2026-03-30T14:22:28Z

What this PR does / why we need it:
Update v1beta2 to standardize flavor into a struct of ID and Filter, similar to other fields.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2896

Special notes for your reviewer:

There is a weird interaction between OpenStackMachine and OpenStackServer as the latter retains the old Flavor and FlavorID

TODOs:

squashed commits
if necessary:
- includes documentation
- adds unit tests

/hold

netlify · 2026-03-30T14:22:35Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`3e049fc`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/69e1d2d8fe611800083794b8
😎 Deploy Preview	https://deploy-preview-3087--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nikParasyr · 2026-04-03T10:51:42Z

/test pull-cluster-api-provider-openstack-e2e-full-test

bnallapeta

Mostly looks good. Minor comments.

bnallapeta · 2026-04-06T04:27:56Z

 	return f.Name == nil && len(f.Tags) == 0
 }

+// FlavorParam describes a nova flavor. It can be specified by ID or filter


perhaps add tests for this one?

I increased the test coverage, can you elaborate on what tests you are missing?

Thanks. I see the new tests.

nikParasyr · 2026-04-14T06:50:28Z

/test pull-cluster-api-provider-openstack-e2e-full-test

nikParasyr · 2026-04-14T06:53:03Z

 	return f.Name == nil && len(f.Tags) == 0
 }

+// FlavorParam describes a nova flavor. It can be specified by ID or filter


I increased the test coverage, can you elaborate on what tests you are missing?

nikParasyr · 2026-04-14T08:14:02Z

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90

Overall really nice!
I have a couple of nits for the unit tests and then a question on what to do with the new filter options that are not fully implemented. See below.

nikParasyr · 2026-04-15T10:48:45Z

/test pull-cluster-api-provider-openstack-e2e-full-test

nikParasyr · 2026-04-15T11:32:52Z

@lentzi90 this is ready for a re-check, i think ive addressed all your remarks

bnallapeta · 2026-04-16T09:19:37Z

/lgtm

lentzi90

Thank you!
This looks ready to merge.
/approve

k8s-ci-robot · 2026-04-16T16:21:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lentzi90 · 2026-04-16T16:21:38Z

/retest

lentzi90 · 2026-04-17T05:34:51Z

/hold cancel

Update v1beta2 to standardize flavor into a struct of ID and Filter, similar to other fields.

bnallapeta · 2026-04-17T06:37:42Z

/lgtm

github-project-automation bot added this to CAPO Roadmap Mar 30, 2026

github-project-automation bot moved this to Inbox in CAPO Roadmap Mar 30, 2026

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2026

k8s-ci-robot requested review from bnallapeta and stephenfin March 30, 2026 14:22

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 30, 2026

nikParasyr force-pushed the v1beta2_flavor branch from d868978 to 2a5f241 Compare March 30, 2026 14:26

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2026

nikParasyr force-pushed the v1beta2_flavor branch 10 times, most recently from 050c69d to 30a045e Compare April 3, 2026 10:10

bnallapeta reviewed Apr 6, 2026

View reviewed changes

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 7, 2026

nikParasyr force-pushed the v1beta2_flavor branch 2 times, most recently from e802d5d to 6d48213 Compare April 14, 2026 06:48

nikParasyr commented Apr 14, 2026

View reviewed changes

nikParasyr force-pushed the v1beta2_flavor branch from 6d48213 to 459c63f Compare April 14, 2026 06:58

nikParasyr force-pushed the v1beta2_flavor branch 3 times, most recently from 37d3ea7 to 982a050 Compare April 14, 2026 07:53

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2026

lentzi90 reviewed Apr 15, 2026

View reviewed changes

Comment thread pkg/webhooks/openstackmachine_webhook_test.go Outdated

Comment thread pkg/webhooks/openstackmachine_webhook_test.go

Comment thread controllers/openstackmachine_controller.go

nikParasyr force-pushed the v1beta2_flavor branch from fb5768c to d807c63 Compare April 15, 2026 09:19

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2026

nikParasyr force-pushed the v1beta2_flavor branch from d807c63 to 86536c5 Compare April 15, 2026 09:39

nikParasyr requested a review from lentzi90 April 15, 2026 12:11

k8s-ci-robot assigned bnallapeta Apr 16, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2026

lentzi90 reviewed Apr 16, 2026

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2026

Standardize flavor in OpenStackMachine

3e049fc

Update v1beta2 to standardize flavor into a struct of ID and Filter, similar to other fields.

nikParasyr force-pushed the v1beta2_flavor branch from 86536c5 to 3e049fc Compare April 17, 2026 06:27

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2026

k8s-ci-robot merged commit 0f0b378 into kubernetes-sigs:main Apr 17, 2026
18 checks passed

github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Apr 17, 2026

nikParasyr deleted the v1beta2_flavor branch April 17, 2026 08:21

Conversation

nikParasyr commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Uh oh!

nikParasyr commented Apr 3, 2026

Uh oh!

bnallapeta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bnallapeta Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

nikParasyr Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

bnallapeta Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

nikParasyr commented Apr 14, 2026

Uh oh!

Uh oh!

Uh oh!

nikParasyr Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

nikParasyr commented Apr 14, 2026

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikParasyr commented Apr 15, 2026

Uh oh!

nikParasyr commented Apr 15, 2026

Uh oh!

bnallapeta commented Apr 16, 2026

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 16, 2026

Uh oh!

lentzi90 commented Apr 16, 2026

Uh oh!

lentzi90 commented Apr 17, 2026

Uh oh!

bnallapeta commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nikParasyr commented Mar 30, 2026 •

edited

Loading

netlify bot commented Mar 30, 2026 •

edited

Loading