[WIP]feat: support allowCrossTenantReplication storage class parameter#3049
Open
andyzhangx wants to merge 2 commits intomasterfrom
Open
[WIP]feat: support allowCrossTenantReplication storage class parameter#3049andyzhangx wants to merge 2 commits intomasterfrom
andyzhangx wants to merge 2 commits intomasterfrom
Conversation
Add allowcrosstenantreplication parameter to StorageClass to control cross-tenant object replication on the storage account. When set to false, the storage account cannot be used as source or destination for cross-tenant replication, following least-privilege principles.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
andyzhangx
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Remove direct vendor modification for AllowCrossTenantReplication. This change should come from cloud-provider-azure first, then be consumed via a vendor bump in this repo.
Contributor
|
@andyzhangx: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
allowcrosstenantreplicationparameter to StorageClass to control cross-tenant object replication on the storage account.Why
Users may want to disable cross-tenant object replication for security compliance (least-privilege). Currently there's no way to configure this via the CSI driver.
Dependency
AllowCrossTenantReplicationtoAccountOptions. After that PR merges, this repo needs a vendor bump before this PR can fully work.Usage
Changes
allowcrosstenantreplicationfield constant inazurefile.gocontrollerserver.goand pass toAccountOptions