Skip to content

fix: replace os.ReadDir with fs.ReadDir(1) to avoid extra memory usage #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyzhangx merged 1 commit into from
Feb 4, 2026
Merged

fix: replace os.ReadDir with fs.ReadDir(1) to avoid extra memory usage #2959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkg/azurefile/nodeserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package azurefile
import (
"encoding/json"
"fmt"
"io"
"os"
"path/filepath"
"runtime"
Expand Down Expand Up @@ -800,7 +801,16 @@ func (d *Driver) ensureMountPoint(target string, perm os.FileMode) (bool, error)

if !notMnt {
// testing original mount point, make sure the mount link is valid
_, err := os.ReadDir(target)
// Use ReadDir(1) instead of full os.ReadDir to avoid expensive directory listing
f, err := os.Open(target)
if err == nil {
defer f.Close()
_, err = f.ReadDir(1)
// EOF means empty directory, which is valid
if err == io.EOF {
err = nil
}
}
if err == nil {
klog.V(2).Infof("already mounted to target %s", target)
return !notMnt, nil
Expand Down
Loading