Skip to content

[release-1.34] fix: optionally skip reading the config from the API server#2942

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-1.34from
k8s-infra-cherrypick-robot:cherry-pick-2940-to-release-1.34
Jan 15, 2026
Merged

[release-1.34] fix: optionally skip reading the config from the API server#2942
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-1.34from
k8s-infra-cherrypick-robot:cherry-pick-2940-to-release-1.34

Conversation

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #2940

/assign andyzhangx

The driver no longer tries to read its config from the API server Secret if `-cloud-config-secret-name` or `-cloud-config-secret-namespace` are empty strings. `AZURE_CREDENTIAL_FILE` must be set and point to a valid config file then.

Skip reading the driver configuration from the API server when
-cloud-config-secret-name or -cloud-config-secret-namespace is explicitly
set to an empty string.

The unit test change is technically not necessary - no unit test actually
tries to get the Secret from provided namespace / name, it only make the
unit test future proof once they start doing so.
@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied January 14, 2026 11:42
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2026
Copy link
Copy Markdown
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@k8s-ci-robot k8s-ci-robot merged commit a07cabe into kubernetes-sigs:release-1.34 Jan 15, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants