Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR aims to remove curl from the Azure File CSI driver Docker image to reduce the attack surface and minimize the image size. The change adds a command to explicitly remove curl from the final container image, as it is not needed for runtime operations.
Key Changes:
- Adds
apt remove curl -ycommand to explicitly remove curl from the final Docker image
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RUN apt remove curl -y | ||
|
|
There was a problem hiding this comment.
This curl removal appears unnecessary since curl is not explicitly installed in the final image stage. Looking at line 37, curl is not included in the clean-install package list. Curl was only installed in the builder stage (line 24), which is discarded during the multi-stage build. Unless curl is being pulled in as a transitive dependency of packages on line 37, this command serves no purpose. Please verify whether curl is actually present in the final image. If it is not present, remove this line. If curl is indeed present as a dependency and needs to be removed, consider combining this with line 37 using && to reduce image layers, following Docker best practices.
| RUN apt remove curl -y |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
cleanup: remove curl in image build since curl is not needed
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: