chore: add CSI-specific Prometheus metrics

[hccheng72]

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR introduces dedicated CSI operation metrics for the AzureDisk CSI driver, separate from the existing Azure cloud provider API metrics, enabling better observability of CSI operations.

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[k8s-ci-robot]

Hi @hccheng72. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull request overview

This pull request adds CSI-specific Prometheus metrics to the Azure Disk CSI Driver, replacing the previous cloud provider metrics implementation. The changes aim to provide better observability for CSI controller and node operations with dedicated metric types and labels.

Changes:

• Introduces a new pkg/metrics package with controller and node operation metrics (counters, histograms, and gauges)
• Replaces cloud provider metrics with CSI-specific metrics across controller and node server operations
• Updates documentation to describe the new metrics and provide usage examples

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 16 comments.

Show a summary per file

File	Description
pkg/metrics/metrics.go	New metrics package defining controller and node operation metrics with registration and helper functions
pkg/azurediskplugin/main.go	Adds metrics registration at driver startup
pkg/azuredisk/nodeserver.go	Replaces cloud provider metrics with CSI metrics for node operations (stage, unstage, publish, unpublish, expand)
pkg/azuredisk/controllerserver.go	Replaces cloud provider metrics with CSI metrics for controller operations (create, delete, modify, publish, unpublish, expand, snapshot)
deploy/example/metrics/README.md	Comprehensive update with new metric descriptions and usage examples

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[landreasyan]

/ok-to-test

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[andyzhangx]

/hold
see comments here: kubernetes-sigs/azurefile-csi-driver#2943 (comment)

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[andyzhangx]

the latency logs are still missing some key columns, could you add back? there are existing kusto query relying on these columns:

• origin
  I0116 17:11:51.778446 1 azure_metrics.go:106] "Observed Request Latency" logger="logLatency" latency_seconds=11.006767806 request="azuredisk_csi_driver_controller_create_volume" resource_group="capz-iequs8" subscription_id="46678f10-4bbb-447e-98e8-d2829589f2d8" source="disk.csi.azure.com" volumeid="/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/capz-iequs8/providers/Microsoft.Compute/disks/pvc-91448383-b866-4255-9ea5-e54f9681e12a" result_code="succeeded"

• with this PR:
  I0116 23:59:07.521827 1 metrics.go:130] "Observed Request Latency" logger="logLatency" request="azuredisk_csi_driver_controller_create_volume" latency_seconds=5.980431424 result_code="succeeded"

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, hccheng72

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/hold cancel

[andyzhangx]

/cherrypick release-1.34

[andyzhangx]

/cherrypick release-1.33

[k8s-infra-cherrypick-robot]

@andyzhangx: cannot checkout release-1.34: error checking out "release-1.34": exit status 1 error: pathspec 'release-1.34' did not match any file(s) known to git

Details

In response to this:

/cherrypick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@andyzhangx: #3464 failed to apply on top of branch "release-1.33":

Applying: chore: add csi specific metrics
Using index info to reconstruct a base tree...
M	pkg/azuredisk/controllerserver.go
M	pkg/azuredisk/nodeserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/nodeserver.go
Auto-merging pkg/azuredisk/controllerserver.go
CONFLICT (content): Merge conflict in pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 chore: add csi specific metrics

Details

In response to this:

/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andyzhangx]

/cherrypick release-1.34

[k8s-infra-cherrypick-robot]

@andyzhangx: cannot checkout release-1.34: error checking out "release-1.34": exit status 1 error: pathspec 'release-1.34' did not match any file(s) known to git

Details

In response to this:

/cherrypick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andyzhangx]

@hccheng72 can you also add the metrics log logic back in blob csi driver? thx

[andyzhangx]

/cherrypick release-1.34

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #3475

Details

In response to this:

/cherrypick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.