fix: respect explicit spreadsheet preview type#772
Open
SpencerZhang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
officePreviewTypewas explicitly supplied by the request or caller.pdf,html,xlsx, andcsvpreview routing for spreadsheet files.Why
When
office.type.web=web, an explicitofficePreviewType=pdfrequest for an xlsx file could still be routed to the xlsx Web preview. Spreadsheet cache naming was also decided before the request-level preview type was applied, so the generated artifact could disagree with the requested mode.This change distinguishes an explicit request override from the configured default and applies it before selecting the cache target and preview page.
Impact
Validation
git diff --checkFileHandlerServiceTestsandOfficeFilePreviewImplTests.com.aspose:aspose-cad:25.10was unavailable from the configured Hzero Maven repository.