fix: apply WithStorageVersionPrecondition in kcp BuildHandlerChainFunc#4262
Open
mjudeikis wants to merge 1 commit into
Open
fix: apply WithStorageVersionPrecondition in kcp BuildHandlerChainFunc#4262mjudeikis wants to merge 1 commit into
mjudeikis wants to merge 1 commit into
Conversation
kcp replaces GenericConfig.BuildHandlerChainFunc entirely, so the BuildHandlerChainWithStorageVersionPrecondition assigned upstream in CreateAggregatorConfig is overwritten and never runs. Apply WithStorageVersionPrecondition explicitly in kcp's chain, gated behind the StorageVersionAPI feature gate (alpha, off by default) to match upstream. Adds the gate to the kcp feature registry, re-exported as kcpfeatures.StorageVersionAPI. Ref: kcp-dev/kubernetes#185
kcp-ci-bot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kcp replaces
GenericConfig.BuildHandlerChainFuncentirely, so theBuildHandlerChainWithStorageVersionPreconditionassigned upstream inCreateAggregatorConfigis overwritten and never runs.Apply
WithStorageVersionPreconditionexplicitly in kcp's chain, gated behind theStorageVersionAPIfeature gate (alpha, off by default) to match upstream. Adds the gate to the kcp feature registry, re-exported askcpfeatures.StorageVersionAPI.Ref: kcp-dev/kubernetes#185
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #
Release Notes