Multi-Hypervisor Abstractions in virt-{controller,operator,handler}#106
Open
harshitgupta1337 wants to merge 11 commits intomsft-mainfrom
Open
Multi-Hypervisor Abstractions in virt-{controller,operator,handler}#106harshitgupta1337 wants to merge 11 commits intomsft-mainfrom
harshitgupta1337 wants to merge 11 commits intomsft-mainfrom
Conversation
Introduce new type HypervisorConfiguration. Add field Hypervisors to KubeVirtConfiguration CRD. Add kubebuilder validations to enforce singleton config one of kvm and hyperv-direct Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Add HypervisorName to KubeVirtDeploymentConfig.AdditionalProperties. Extract HypervisorName from KubeVirtConfiguration. Invoke the LauncherResourceRenderer interface to fech hypervisor dev and virtType to pass to node-labeller. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
c319a69 to
8fd450b
Compare
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
8fd450b to
ce7797e
Compare
ce7797e to
538a1df
Compare
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
73fb51e to
43ddc89
Compare
1f40519 to
b66451d
Compare
b66451d to
9d9c6b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
After this PR:
References
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note