Skip to content
This repository was archived by the owner on Aug 22, 2022. It is now read-only.

[zerotier] New chart for zerotier network#1613

Open
mabels wants to merge 4 commits intok8s-at-home:masterfrom
mabels:master
Open

[zerotier] New chart for zerotier network#1613
mabels wants to merge 4 commits intok8s-at-home:masterfrom
mabels:master

Conversation

@mabels
Copy link
Copy Markdown

@mabels mabels commented Jun 8, 2022

Description of the change

Added a new Chart to enable ZeroTier Networking

Benefits

You could do in future hopefully
helm install zerotier k8s-at-home/zerotier

Possible drawbacks

I don't know --- keep in mind hostNetwork is default true!

Applicable issues

unknown

  • fixes #

no

Checklist

  • [ x] Title of the PR starts with chart name (e.g. [home-assistant])
  • [ x] Chart version bumped in Chart.yaml according to semver.
  • [ x] Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
  • [ x] Variables have been documented in the values.yaml file.

@ghost ghost added the size/L Categorises a PR that changes 100-499 lines, ignoring generated files. label Jun 8, 2022
Comment thread charts/incubator/zerotier/values.yaml Outdated
# -- image tag
# currently there is no zerotier manifest which
# allow to have a arch generic tag
tag: 1.8.10-arm64
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag should probably default to the amd64 variant

Copy link
Copy Markdown
Author

@mabels mabels Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not --- changed --- my default is arm64 these days

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabels You need to use 1.8.10 as tag for the amd64 image.

@ghost ghost added the precommit:failed CI status: pre-commit validation failed label Jun 8, 2022
@ghost ghost added precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful and removed precommit:failed CI status: pre-commit validation failed labels Jun 9, 2022
@truxnell truxnell closed this Jun 10, 2022
@truxnell truxnell reopened this Jun 10, 2022
@ghost ghost added lint:failed CI status: linting failed install:failed CI status: install failed labels Jun 10, 2022
@truxnell
Copy link
Copy Markdown
Member

@mabels looks like theres still some linting to fix & the new image tag cant be pulled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog:ok CI status: changelog validation successful install:failed CI status: install failed lint:failed CI status: linting failed precommit:ok CI status: pre-commit validation successful size/L Categorises a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants