Conversation
- Added map pipeline documentation showing syntax: {var|map[key:val,...]}
- Emphasized that unmapped values pass through unchanged
- Added critical warning about pipeline order
- Clarified that map should come BEFORE options[strict] for validation
- Added concrete example showing correct usage
This addresses the missing UI documentation that caused user confusion
about how to properly chain map with strict validation.
Adds a comprehensive real-world example demonstrating the power of the templating system by combining map and strict options pipelines. Example bookmark: - pr dr p -> https://drive.proton.me/photos - pr mail -> https://mail.proton.me - pr vpn -> https://vpn.proton.me Features demonstrated: - Map shortcuts to full names: m->mail, cal->calendar, dr->drive - Strict validation ensuring only valid products are allowed - Optional subproducts with their own map+strict pipeline - Correct pipeline order: map BEFORE options[strict] for validation Added comprehensive tests: - Product shortcuts (dr, m, cal) - Full product names (vpn, mail, calendar) - Subproduct shortcuts (p, d, s) - Optional subproduct omission - Invalid product/subproduct rejection - Pipeline order correctness vs incorrectness YAML fix: - Quoted description field to avoid parsing colons as YAML mappings
Expands the Template Syntax section with: - Complete list of all pipeline operations - Clear distinction between basic variables and pipelines - Comprehensive Proton bookmark example demonstrating real-world power - Concrete usage examples showing shortcuts in action - Critical warning about pipeline order (map before options[strict]) The example showcases how combining map and strict options creates a powerful, user-friendly interface with shortcuts like 'dr' → 'drive' while maintaining strict validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.