feat: allow topping up non-relayer addresses#96
Open
zannis wants to merge 3 commits intojoshstevens19:masterfrom
Open
feat: allow topping up non-relayer addresses#96zannis wants to merge 3 commits intojoshstevens19:masterfrom
zannis wants to merge 3 commits intojoshstevens19:masterfrom
Conversation
|
@zannis is attempting to deploy a commit to the joshaavecom's projects Team on Vercel. A member of the Team first needs to authorize it. |
joshstevens19
requested changes
Mar 20, 2026
| ``` | ||
|
|
||
| :::info | ||
| `additional_addresses` requires `advanced.allow_non_relayer_topups: true` at the top level of your config. Without it, the additional addresses will be ignored. |
Owner
There was a problem hiding this comment.
any reason we need allow_non_relayer_topups? cant we assume if you add additional_addresses your motive is to top them up?
Contributor
Author
There was a problem hiding this comment.
yeah fair - the idea was to expose an AdvancedConfig to explicitly allow this and also as a base to add more advanced features later on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.